Fix image push tests permissions in CI#128
Fix image push tests permissions in CI#128Siddhant-K-code wants to merge 3 commits intoapple:mainfrom
Conversation
|
Thanks for the PR! Will take a deeper look and get back! In the meantime could you please set up commit signing and re push your commits? |
Siddhant-K-code
force-pushed
the
fix/image-push-tests-permissions
branch
from
0b27707 to
825f0ad
Compare
|
Thanks, I've signed the commit |
Siddhant-K-code
force-pushed
the
fix/image-push-tests-permissions
branch
from
c2b4575 to
f044c26
Compare
|
👋🏻 @adityaramani, any progress on this? |
|
Hi @Siddhant-K-code, please run |
Siddhant-K-code
force-pushed
the
fix/image-push-tests-permissions
branch
from
8b94a70 to
108db95
Compare
Siddhant-K-code
force-pushed
the
fix/image-push-tests-permissions
branch
from
108db95 to
4fac487
Compare
adityaramani
left a comment
adityaramani
left a comment
There was a problem hiding this comment.
Sorry for the long delay.
I like the update to the ImageStoreTests, but Im not sure about the RegistryClientTests
Do you want to back that out from the PR and we can re-think if there is a better way to do it?
adityaramani
left a comment
adityaramani
left a comment
There was a problem hiding this comment.
Thanks! Looks good! Just two small comments
Siddhant-K-code
force-pushed
the
fix/image-push-tests-permissions
branch
from
602f4a5 to
7e45ae0
Compare
|
Looks like you need to run |
|
This is pretty stale now. Lets close this and if it still needs to be address we can open a new change on the new codebase. |
|
@crosbymichael - I am unsure, what was the missing piece from the change. But, i respect your decision to close the PR! |
|
@Siddhant-K-code It was mostly because of how old the change was. Thank you for understanding. |
5 participants
Implemented a mock-based testing approach that validates push functionality without requiring external registry permissions.
fixes #56